diff options
author | Jannis M. Hoffmann <jannis.hoffmann@rwth-aachen.de> | 2022-05-09 22:57:17 +0200 |
---|---|---|
committer | Jannis M. Hoffmann <jannis.hoffmann@rwth-aachen.de> | 2022-05-09 22:57:17 +0200 |
commit | 6ed400461bb2429a5818c58a0a5b92f555700edc (patch) | |
tree | dd0138dd71462311c95dfdd1af4384efd1e66470 /lib/JWebmail/Model | |
parent | 73503d87d3f9f87a73616bd3f4365906c87ae13e (diff) |
some small fixes by perlcritc
Diffstat (limited to 'lib/JWebmail/Model')
-rw-r--r-- | lib/JWebmail/Model/ReadMails/MockJSON.pm | 2 | ||||
-rw-r--r-- | lib/JWebmail/Model/ReadMails/MockMaildir.pm | 2 | ||||
-rw-r--r-- | lib/JWebmail/Model/ReadMails/QMailAuthuser.pm | 6 | ||||
-rw-r--r-- | lib/JWebmail/Model/ReadMails/Role.pm | 2 |
4 files changed, 6 insertions, 6 deletions
diff --git a/lib/JWebmail/Model/ReadMails/MockJSON.pm b/lib/JWebmail/Model/ReadMails/MockJSON.pm index 345573c..1a16ef6 100644 --- a/lib/JWebmail/Model/ReadMails/MockJSON.pm +++ b/lib/JWebmail/Model/ReadMails/MockJSON.pm @@ -21,7 +21,7 @@ use constant { with 'JWebmail::Model::ReadMails::Role'; -sub new { bless {} } +sub new { bless {}, shift } sub _read_json_file { my ($file_name) = @_; diff --git a/lib/JWebmail/Model/ReadMails/MockMaildir.pm b/lib/JWebmail/Model/ReadMails/MockMaildir.pm index d1746ec..2df4fa9 100644 --- a/lib/JWebmail/Model/ReadMails/MockMaildir.pm +++ b/lib/JWebmail/Model/ReadMails/MockMaildir.pm @@ -35,7 +35,7 @@ sub build_and_run { my $args = shift; my $mail_user = 'maildir'; - my $exec = $EXTRACTORS{$self->extractor} . ' ' . join(' ', map { $_ =~ s/(['\\])/\\$1/g; "'$_'" } ($self->maildir, $self->user, $mail_user, $mode, @$args)); + my $exec = $EXTRACTORS{$self->extractor} . ' ' . join(' ', map { my $x = s/(['\\])/\\$1/gr; "'$x'" } ($self->maildir, $self->user, $mail_user, $mode, @$args)); my $pid = open(my $reader, '-|', $exec) or die 'failed to create subprocess'; diff --git a/lib/JWebmail/Model/ReadMails/QMailAuthuser.pm b/lib/JWebmail/Model/ReadMails/QMailAuthuser.pm index 09b8b9d..d0d2b3c 100644 --- a/lib/JWebmail/Model/ReadMails/QMailAuthuser.pm +++ b/lib/JWebmail/Model/ReadMails/QMailAuthuser.pm @@ -31,7 +31,7 @@ package JWebmail::Model::ReadMails::QMailAuthuser::Error { $self->{data} = $_[0] if @_ == 1; $self->{data} = [@_] if @_ > 1; - return bless $self; + return bless $self, $cls; } sub to_string { @@ -169,7 +169,7 @@ sub build_arg { return $self->{qmail_dir}.'/bin/qmail-authuser' . $self->{prefix} . ' ' - . join(' ', map { s/(['\\])/\\$1/g; "'$_'" } ($self->{prog}, $self->{maildir}, $self->{user}, $user_name, $mode, @$args)) + . join(' ', map { my $x = s/(['\\])/\\$1/gr; "'$x'" } ($self->{prog}, $self->{maildir}, $self->{user}, $user_name, $mode, @$args)) . ' 3<&0' . ' 2>>'.$self->{logfile}; } @@ -188,7 +188,7 @@ sub execute { close $writer or die 'closing write pipe failed'; - binmode $reader, ':utf8'; + binmode $reader, ':encoding(UTF-8)'; my $input = <$reader>; close $reader or die 'closing read pipe failed'; diff --git a/lib/JWebmail/Model/ReadMails/Role.pm b/lib/JWebmail/Model/ReadMails/Role.pm index 466e3b0..593672c 100644 --- a/lib/JWebmail/Model/ReadMails/Role.pm +++ b/lib/JWebmail/Model/ReadMails/Role.pm @@ -9,7 +9,7 @@ package JWebmail::Model::ReadMails::Role::Shadow { use overload '""' => sub { '***' }; - sub new { shift; bless \(shift.'') } + sub new { my $cls = shift; bless \(shift.''), $cls } sub show_password { ${shift()} } |