From b36eada764601355be4616fb92822ffabdcb1dc8 Mon Sep 17 00:00:00 2001
From: "Jannis M. Hoffmann" <jannis.hoffmann@rwth-aachen.de>
Date: Sun, 22 May 2022 16:31:21 +0200
Subject: fixes for lint issues

---
 lib/JWebmail/Model/ReadMails/Role.pm | 2 +-
 lib/JWebmail/Model/WriteMails.pm     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

(limited to 'lib/JWebmail/Model')

diff --git a/lib/JWebmail/Model/ReadMails/Role.pm b/lib/JWebmail/Model/ReadMails/Role.pm
index 593672c..1f4390b 100644
--- a/lib/JWebmail/Model/ReadMails/Role.pm
+++ b/lib/JWebmail/Model/ReadMails/Role.pm
@@ -56,7 +56,7 @@ around @methods => sub {
     my $succ = eval { @res = $orig->(@_); 1 };
     $_[1]->{password} = $safe;
     die unless $succ;
-    return wantarray ? @res : $res[$#res];
+    return wantarray ? @res : $res[-1];
 };
 
 around read_headers_for => sub {
diff --git a/lib/JWebmail/Model/WriteMails.pm b/lib/JWebmail/Model/WriteMails.pm
index 7a50bcb..f4d09e8 100644
--- a/lib/JWebmail/Model/WriteMails.pm
+++ b/lib/JWebmail/Model/WriteMails.pm
@@ -24,13 +24,13 @@ sub _build_mail {
         },
         body_str => $mail->{message},
     );
-    my $attach = Email::MIME->create(
+    my $attach = $mail->{attach} ? Email::MIME->create(
         attributes => {
             content_type => $mail->{attach_type},
             encoding     => 'base64',
         },
         body => $mail->{attach}->asset->slurp,
-    ) if $mail->{attach};
+    ) : undef;
 
     my $email = Email::MIME->create(
         header_str => [
-- 
cgit v1.2.3