From d0ffe11bd365b68d4da252b39d06d99f75d8cacb Mon Sep 17 00:00:00 2001 From: "Jannis M. Hoffmann" Date: Wed, 16 Nov 2022 23:14:10 +0100 Subject: minor cleanup and fixes --- lib/JWebmail/Plugin/ServerSideSessionData.pm | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) (limited to 'lib/JWebmail/Plugin/ServerSideSessionData.pm') diff --git a/lib/JWebmail/Plugin/ServerSideSessionData.pm b/lib/JWebmail/Plugin/ServerSideSessionData.pm index 94e8f25..c28f6d1 100644 --- a/lib/JWebmail/Plugin/ServerSideSessionData.pm +++ b/lib/JWebmail/Plugin/ServerSideSessionData.pm @@ -42,7 +42,7 @@ sub _rw_cleanup_file { close $lock; chomp $pid; if (!$rmlock && (!$pid || !-e "/proc/$pid")) { - $lock_name->remove; + $lock_name->remove(); $rmlock = 1; next; } @@ -60,7 +60,7 @@ sub _rw_cleanup_file { use autodie; open(my $info, -e $info_name ? '+<' : '+>', $info_name); - my $next_time = $info->getline // ''; + my $next_time = $info->getline() // ''; $next_time = 0 unless $next_time =~ /^\d+$/a; chomp $next_time; if ($next_time > $time) { @@ -77,7 +77,7 @@ sub _rw_cleanup_file { return 1; } }; - $lock_name->remove; + $lock_name->remove(); return $ret; } @@ -89,7 +89,7 @@ sub cleanup_files { if ($self->_next_cleanup < $t && $self->_rw_cleanup_file($t)) { for ($self->session_directory->list->each) { if ( $_->stat->mtime + $self->expiration < $t ) { - $_->remove; + $_->remove(); } } } @@ -102,7 +102,7 @@ sub s3d { my ($key, $val) = @_; # cleanup old sessions - $self->cleanup_files; + $self->cleanup_files(); my $file = $self->session_directory->child($c->session(S_KEY) || $c->req->request_id . $$); @@ -111,16 +111,16 @@ sub s3d { truncate $file, 0; } else { - $file->touch; + $file->touch(); } } elsif (defined $val) { - $file->touch; + $file->touch(); $file->chmod(0600); $c->session(S_KEY, $file->basename); } - my $data = -s $file ? decode_json($file->slurp) : {}; + my $data = -s $file ? decode_json($file->slurp()) : {}; if (defined $val) { # set $data->{$key} = $val; @@ -147,7 +147,7 @@ sub register { or $! ? die "failed to create directory: $!" : 1; } - $self->cleanup_files; + $self->cleanup_files(); $app->helper( s3d => sub { $self->s3d(@_) } ); $app->helper( s3d_close => sub { delete shift->session->{S_KEY()} } ); -- cgit v1.2.3